View Bug Details

IDProjectCategoryView StatusLast Update
0002016DCP-o-maticFeaturespublic2023-09-01 21:52
Reportercarl Assigned Tocarl  
PrioritynormalSeverityminorReproducibilityN/A
Status closedResolutionduplicate 
Target Version2.16.31 
Summary0002016: Make divider between controls and view draggable
Description

[]

TagsNo tags attached.
Branchanother-divider
Estimated weeks required
Estimated work requiredUndecided

Relationships

duplicate of 0002350 closedcarl Make side panel resizable 

Activities

carl

2022-10-11 23:52

administrator   ~0005261

Make sure 0001982 doesn't come back on this branch.

carl

2022-10-12 00:02

administrator   ~0005262

works (3,404 bytes)   
diff --git a/src/tools/dcpomatic.cc b/src/tools/dcpomatic.cc
index 772d90050..d5469b321 100644
--- a/src/tools/dcpomatic.cc
+++ b/src/tools/dcpomatic.cc
@@ -348,24 +348,28 @@ public:
 		Bind (wxEVT_CLOSE_WINDOW, boost::bind (&DOMFrame::close, this, _1));
 		Bind (wxEVT_SHOW, boost::bind (&DOMFrame::show, this, _1));
 
-		/* Use a panel as the only child of the Frame so that we avoid
-		   the dark-grey background on Windows.
-		*/
-		auto overall_panel = new wxPanel (this, wxID_ANY);
+		auto splitter = new wxSplitterWindow(this, wxID_ANY);
+		auto right_panel = new wxPanel(splitter, wxID_ANY);
+
+		auto piss = new wxPanel(splitter, wxID_ANY);
 
-		_film_viewer.reset (new FilmViewer (overall_panel));
-		_controls = new StandardControls (overall_panel, _film_viewer, true);
-		_film_editor = new FilmEditor (overall_panel, _film_viewer);
-		auto job_manager_view = new JobManagerView (overall_panel, false);
+		_film_viewer.reset (new FilmViewer (right_panel));
+		_controls = new StandardControls (right_panel, _film_viewer, true);
+		_film_editor = new FilmEditor (piss, _film_viewer);
+		auto job_manager_view = new JobManagerView (right_panel, false);
 
 		auto right_sizer = new wxBoxSizer (wxVERTICAL);
 		right_sizer->Add (_film_viewer->panel(), 2, wxEXPAND | wxALL, 6);
 		right_sizer->Add (_controls, 0, wxEXPAND | wxALL, 6);
 		right_sizer->Add (job_manager_view, 1, wxEXPAND | wxALL, 6);
 
-		wxBoxSizer* main_sizer = new wxBoxSizer (wxHORIZONTAL);
-		main_sizer->Add (_film_editor, 0, wxEXPAND | wxALL, 6);
-		main_sizer->Add (right_sizer, 1, wxEXPAND | wxALL, 6);
+		right_panel->SetSizer(right_sizer);
+
+		auto shit = new wxBoxSizer(wxHORIZONTAL);
+		shit->Add(_film_editor, 1, wxEXPAND);
+		piss->SetSizer(shit);
+
+		splitter->SplitVertically(piss, right_panel);
 
 		set_menu_sensitivity ();
 
@@ -374,8 +378,6 @@ public:
 
 		JobManager::instance()->ActiveJobsChanged.connect(boost::bind(&DOMFrame::active_jobs_changed, this));
 
-		overall_panel->SetSizer (main_sizer);
-
 		UpdateChecker::instance()->StateChanged.connect(boost::bind(&DOMFrame::update_checker_state_changed, this));
 
 		FocusManager::instance()->SetFocus.connect (boost::bind (&DOMFrame::remove_accelerators, this));
diff --git a/src/wx/content_panel.cc b/src/wx/content_panel.cc
index 6e0864417..41518d027 100644
--- a/src/wx/content_panel.cc
+++ b/src/wx/content_panel.cc
@@ -134,7 +134,7 @@ ContentPanel::ContentPanel (wxNotebook* n, shared_ptr<Film> film, weak_ptr<FilmV
 	{
 		auto s = new wxBoxSizer (wxHORIZONTAL);
 
-		_content = new wxListCtrl (_top_panel, wxID_ANY, wxDefaultPosition, wxSize (320, 160), wxLC_REPORT | wxLC_NO_HEADER);
+		_content = new wxListCtrl (_top_panel, wxID_ANY, wxDefaultPosition, wxSize(-1, 160), wxLC_REPORT | wxLC_NO_HEADER);
 		_content->DragAcceptFiles (true);
 		s->Add (_content, 1, wxEXPAND | wxTOP | wxBOTTOM, 6);
 
diff --git a/src/wx/film_editor.cc b/src/wx/film_editor.cc
index 2ec174260..365d3bffe 100644
--- a/src/wx/film_editor.cc
+++ b/src/wx/film_editor.cc
@@ -55,7 +55,7 @@ FilmEditor::FilmEditor (wxWindow* parent, weak_ptr<FilmViewer> viewer)
 	auto s = new wxBoxSizer (wxVERTICAL);
 
 	_main_notebook = new wxNotebook (this, wxID_ANY);
-	s->Add (_main_notebook, 1);
+	s->Add (_main_notebook, 1, wxEXPAND);
 
 	_content_panel = new ContentPanel (_main_notebook, _film, viewer);
 	_main_notebook->AddPage (_content_panel->window(), _("Content"), true);
works (3,404 bytes)   

Bug History

Date Modified Username Field Change
2021-05-25 20:44 carl New Bug
2022-10-11 23:42 carl Assigned To => carl
2022-10-11 23:42 carl Status new => in progress
2022-10-11 23:44 carl Branch => another-divider
2022-10-11 23:44 carl Estimated work required => Undecided
2022-10-11 23:45 carl Target Version => 2.16.30
2022-10-11 23:52 carl Note Added: 0005261
2022-10-12 00:02 carl Note Added: 0005262
2022-10-12 00:02 carl File Added: works
2022-10-12 11:53 carl Target Version 2.16.30 => 2.16.31
2022-10-12 21:52 carl Relationship added duplicate of 0002350
2022-10-14 19:05 carl Status in progress => resolved
2022-10-14 19:05 carl Resolution open => duplicate
2023-09-01 21:52 carl Status resolved => closed